Opening save files doesn't work in Edge or IE

bmaupin / civ5save-editor

Civilization V save editor

https://bmaupin.github.io/civ5save-editor/

MIT License

28 stars 2 forks source link

Opening save files doesn't work in Edge or IE #2

Closed bmaupin closed 7 years ago

bmaupin commented 7 years ago

Clicking Open save file or Demo starts the progress spinner and then nothing else happens. No errors or other messages appear in the console.

Also affects Safari 9.

bmaupin commented 7 years ago

Comparing JS functionality between Safari and Edge on caniuse.com, seems like the issue is probably Edge/IE doesn't implement File constructor (http://caniuse.com/#feat=fileapi).

Other possibilities:

JavaScript modules via script tag - are we even using this?
TextDecoder - shouldn't be an issue since we're using a workaround

Possible workaround: use the Blob constructor instead (https://stackoverflow.com/a/43241922/399105)

bmaupin commented 7 years ago

Fixed for Edge with https://github.com/bmaupin/react-civ5save-editor/commit/f337c84e2abdfd8cdc297bf21d4738c25e2b651a

IE is effectively a discontinued product, so closing this.