bmaupin
commented
2 years ago Seems to be caused by this bug: https://github.com/gjtorikian/html-proofer/issues/773
It was fixed in 4.4.3, but the GitHub Action we're using hasn't been upgraded, apparently because the build is failing: https://github.com/chabad360/htmlproofer/actions
There's already a bug for it: https://github.com/chabad360/htmlproofer/issues/10
The creator of that action does seem to be semi-active on GitHub: https://github.com/chabad360
but ... this isn't the first time this action has broken, and there's another upcoming breaking change with HTMLProofer v5: https://github.com/gjtorikian/html-proofer/pull/758
One of the biggest issues with https://github.com/chabad360/htmlproofer is that it isn't pinned to a specific version of HTMLProofer: https://github.com/chabad360/htmlproofer/blob/master/action.yml
And the container image itself just gets overwritten with the newest version, so there's no way to pin that either: https://hub.docker.com/r/chabad360/htmlproofer
At this point, I think the best path forward is to migrate to a different GitHub Action. This one has more stars: https://github.com/anishathalye/proof-html
Plus it's pinned to a specific container image: https://github.com/anishathalye/proof-html/blob/master/action.yml
And old versions of the container image are preserved: https://hub.docker.com/r/anishathalye/proof-html/tags
https://github.com/bmaupin/wiki/actions/runs/3229240322/jobs/5286303080