search

bmavity / ges-client

A node.js client library for (Get) Event Store
Other
30 stars 9 forks source link

Transactions #31

Closed bmavity closed 9 years ago

bmavity commented 9 years ago

Migrated all transaction tests

gregoryyoung commented 9 years ago

Looks good

On Monday, October 20, 2014, Brian Mavity notifications@github.com wrote:

Migrated all transaction tests

You can merge this Pull Request by running

git pull https://github.com/bmavity/ges-client transactions

Or view, comment on, or merge it at:

https://github.com/bmavity/ges-client/pull/31 Commit Summary

  • Initial transaction test is passing
  • Remaining transaction tests now pass
  • Committing empty transaction tests now migrated
  • isjson flag tests now migrated
  • All transaction tests now passing

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/pull/31.

Studying for the Turing test

bmavity commented 9 years ago

Almost there. :)

gregoryyoung commented 9 years ago

I imagine the clustering fall over is one of the more involved parts

On Monday, October 20, 2014, Brian Mavity notifications@github.com wrote:

Almost there. :)

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/pull/31#issuecomment-59726094.

Studying for the Turing test

bmavity commented 9 years ago

Clustering will be an adventure. Some other things need to be cleaned up, reconnects added, etc. But all the basic functionality is in now in there.

gregoryyoung commented 9 years ago

Also have you seen the competing branch? Most of the operations are very simple to add client wise. See diff of .proto files.

On Monday, October 20, 2014, Brian Mavity notifications@github.com wrote:

Clustering will be an adventure. Some other things need to be cleaned up, reconnects added, etc. But all the basic functionality is in now in there.

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/pull/31#issuecomment-59727585.

Studying for the Turing test

bmavity commented 9 years ago

Will check it out as soon as I get the auth tests migrated and figure out the bug in the catch up subscription. I'm still on 3.0.0RC and will look at competing when I upgrade.

On Mon, Oct 20, 2014 at 6:06 AM, Greg Young notifications@github.com wrote:

Also have you seen the competing branch? Most of the operations are very simple to add client wise. See diff of .proto files.

On Monday, October 20, 2014, Brian Mavity notifications@github.com wrote:

Clustering will be an adventure. Some other things need to be cleaned up, reconnects added, etc. But all the basic functionality is in now in there.

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/pull/31#issuecomment-59727585.

Studying for the Turing test

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/pull/31#issuecomment-59727691.