search

bmavity / ges-client

A node.js client library for (Get) Event Store
Other
30 stars 9 forks source link

Tcp disconnect doesn't emit an error on tcpConnection #41

Open nicdex opened 9 years ago

nicdex commented 9 years ago

When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't take any compensating actions.

I think I could submit a PR for this one.

gregoryyoung commented 9 years ago

In the other clients we have events that get passed back and we have reconnection etc strategies to prevent people from writing the same boilerplate.

On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze notifications@github.com wrote:

When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't take any compensating actions.

I think I could submit a PR for this one.

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41.

Studying for the Turing test

bmavity commented 9 years ago

Things stalled a bit before I got to the connection events. I am preparing a new release, but can't promise if connection events would get in. However, I would not be opposed to a pull request. :)

B

On Wed, Aug 26, 2015 at 11:42 AM, Greg Young notifications@github.com wrote:

In the other clients we have events that get passed back and we have reconnection etc strategies to prevent people from writing the same boilerplate.

On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze < notifications@github.com> wrote:

When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't take any compensating actions.

I think I could submit a PR for this one.

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41.

Studying for the Turing test

— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41#issuecomment-135102625.

nicdex commented 9 years ago

Yeah Greg I know.

For now I only want to have the error bubble up as a start, but eventually it would be nice to have the reconnect done by the ges-client too.

We're about to go into alpha for our product today using ges-client and GES so I guess we'll see a lot of issues. I'll try to get the OK to submit PR fixes for issues we see and can fix.

Thanks.

bmavity commented 9 years ago

It's part of the "plan".

bmavity commented 9 years ago

Created a parent issue for all issues awaiting Connection work #44