bmax121 / APatch

The patching of Android kernel and Android system
GNU General Public License v3.0
4.75k stars 356 forks source link

Change memory for module.img #375

Closed Zenlua closed 7 months ago

Zenlua commented 7 months ago

Add storage like ksu to avoid the problem of not enough throughput if the flash module is heavy.

If you remove module.img so that the directory is the same as magisk, even better

Screenshot_2024-04-11-22-56-23-201_bin mt plus-edit

Skorpion96 commented 7 months ago

This willl break TWRP backups, people still don't understand this..... Already doing twrp backups with KSU became impossible, and kernelsu workarounds on the wiki don't work as if you shrink the modules image the modules break, so no doing this change is simply nosense in my opinion. The only thing would be to offer the choice to the user to do this or not maybe but for example I wouldn't as then twrp backups would become unfeasible and them are more important than some stupid module honestly (at least for me)

xxjoe2 commented 7 months ago

agreed, this is why i switched from ksu to ap

Skorpion96 commented 7 months ago

I really don't know how to pray APatch creator to close this as unfeasible..... Please don't ruin apatch as well.....

Zenlua commented 7 months ago

If you don't want to increase the size of the img module file, then delete the img module because it's not suitable. If the module is faulty, leave it like magisk.

xxjoe2 commented 7 months ago

it really hard to handle that 1T sparse file, i tried to do a backup under recovery, but native twrp doesnt work (size exceeded). i backup with tar (sparse file supported) and it took more than an hour to complete, just the adb folder!!

so pls dont go back to sparse file

0x0021 commented 7 months ago

我拒绝😡

Zenlua commented 7 months ago

it really hard to handle that 1T sparse file, i tried to do a backup under recovery, but native twrp doesnt work (size exceeded). i backup with tar (sparse file supported) and it took more than an hour to complete, just the adb folder!!

so pls dont go back to sparse file

Just compress module.img into zip and delete module.img it won't take up space.

Admirepowered commented 7 months ago

not consider