bmax121 / APatch

The patching of Android kernel and Android system
GNU General Public License v3.0
3.46k stars 276 forks source link

APatch granting root permission AUTOMATICALLY when INSTALLING apps #508

Closed gyrorayo closed 2 weeks ago

gyrorayo commented 3 weeks ago

Please check before submitting an issue/在提交 issue 前请检查

Version requirement/版本要求

Describe the bug/描述 bug

Apps like Termux or Zarchiver Pro are automatically added to Superuser list when installed from Play Store. Didn't have the issue when installing via file manager (ReVanced Manager, AdAway)

Reproduce method/复现方法

Expected behavior/预期行为

Not adding newly installed apps to Superuser allow list automatically, user should determine whether or not granting superuser permission to apps, even if they do support root functions.

Actual behaviour /实际行为

When installing apps such as ZArchiver Pro and Termux via Play Store, are automatically added to superuser ALLOW list.

Screenshots/截图

No response

Logs/日志

No response

Device Name/设备名称

Redmi Note 13 4G (Sapphire)

OS Version/系统版本

HyperOS 1.0.3 by xiaomi.eu (Android14)

APatch Version/APatch 版本

10763

Kernel Version/内核版本

android13-5.15.123

KernelPatch Version/KernelPatch 版本

0.10.7

Additional context/其他信息

I assume that the only app that should be allowed automatically is Shell (com.android.shell)

crystle01 commented 2 weeks ago

Autostarts is another app that was granted root without permission, installed from fdroid.

pomelohan commented 2 weeks ago

Can you reproduce this bug on CI Version?

MIkeeJY commented 2 weeks ago

@pomelohan related with https://github.com/bmax121/APatch/issues/386

gyrorayo commented 2 weeks ago

Can you reproduce this bug on CI Version?

sorry, I'm being ignorant, what's CI ver? how can I get it to test?

pomelohan commented 2 weeks ago

Can you reproduce this bug on CI Version?

sorry, I'm being ignorant, what's CI ver? how can I get it to test?

https://github.com/bmax121/APatch/actions/runs/9528468081/artifacts/1604807636

pomelohan commented 2 weeks ago

@pomelohan related with #386

I don't think it's the same problem

gyrorayo commented 2 weeks ago

Can you reproduce this bug on CI Version?

sorry, I'm being ignorant, what's CI ver? how can I get it to test?

https://github.com/bmax121/APatch/actions/runs/9528468081/artifacts/1604807636

Thanks, quick question, do I need to patch boot.img again? or just update manager?

pomelohan commented 2 weeks ago

Can you reproduce this bug on CI Version?

sorry, I'm being ignorant, what's CI ver? how can I get it to test?

https://github.com/bmax121/APatch/actions/runs/9528468081/artifacts/1604807636

Thanks, quick question, do I need to patch boot.img again? or just update manager?

  1. Update Manager
  2. Repatch boot image with new manager
  3. Update AndroidPatch
  4. Try
gyrorayo commented 2 weeks ago

Can you reproduce this bug on CI Version?

sorry, I'm being ignorant, what's CI ver? how can I get it to test?

https://github.com/bmax121/APatch/actions/runs/9528468081/artifacts/1604807636

Thanks, quick question, do I need to patch boot.img again? or just update manager?

  1. Update Manager
  2. Repatch boot image with new manager
  3. Update AndroidPatch
  4. Try

Done, reflashed newly patched boot.img, updated AndroidPatch. Reinstalled Zarchiver and Termux, APatch DIDN'T grant permissions automatically, so it's solved!

Thank you so much for the support. I'm loving APatch btw.

pomelohan commented 2 weeks ago

Thanks for supporting us🌹