Using @fa-version when Slash arguments is set to Off triggers HTTP 404.

bmbrands / moodle-theme_elegance

This is the new official elegance repository

http://basbrands.nl

23 stars 12 forks source link

Using @fa-version when Slash arguments is set to Off triggers HTTP 404. #153

Closed scara closed 8 years ago

scara commented 8 years ago

More details in https://moodle.org/mod/forum/discuss.php?d=325511.

scara commented 8 years ago

Another option is to get rid of @fa-version and trust the cache killing provided by the Moodle theme framework (=> revision numeric id), which guarantees that by bumping the theme version a new value will be generated.

The current PR keeps that value but fix the way the version is appended to the font URL.

bmbrands commented 8 years ago

Thanks for fixing this Matteo!