search

bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

Remember Username Checkbox on Login Page Doesn't work #40

Closed jmbragg closed 10 years ago

jmbragg commented 10 years ago

Username box is blank when logging in.

To reproduce:

  1. Go to Login page, enter username/password and click Remember username box. Login.
  2. Logout.
  3. Return to Login page. Should show username in the the username box but it doesn't.

Works in Bootstrap.

thedannywahl commented 10 years ago

I believe this is because of changes in the core /login/ folder - and the fact that login isn't a renderer. So new methods were added in 2.7 that haven't been added in the elegance login.php. I'm not sure that there's a viable custom login.php that can support 2.6 and 2.7 We may have to remove the custom login.php option until /login/ is a renderer.

jmbragg commented 10 years ago

‎Oh that's awful. That's really a shame. It looks so good.  From: Danny Wahl‎Sent: Thursday, July 17, 2014 8:06 PMTo: thedannywahl/moodle-theme_eleganceReply To: thedannywahl/moodle-theme_eleganceCc: jmbraggSubject: Re: [moodle-theme_elegance] Remember Username Checkbox on Login Page Doesn't work (#40)I believe this is because of changes in the core /login/ folder - and the fact that login isn't a renderer. So new methods were added in 2.7 that haven't been added in the elegance login.php. I'm not sure that there's a viable custom login.php that can support 2.6 and 2.7 We may have to remove the custom login.php option until /login/ is a renderer.

—Reply to this email directly or view it on GitHub.

thedannywahl commented 10 years ago

'fixed' by c018999c8dff7d994de306745822a52288955e16 @TODO: refactor /login to support all new methods- might not be possible!

thedannywahl commented 10 years ago

see #66 for followup.