bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

Login page footer issue on bigger screens #48

Closed demontech closed 10 years ago

demontech commented 10 years ago

Hi all,

I updated the files to fix issue #23, but after that, the footer size is really big. You just notice this in big screen monitors, for small monitors it looks fine.

This capture is on a 27" screen monitor

image

thedannywahl commented 10 years ago

yeah, either the footer will float and the drawing won't take 100% of the height (older bug #23) or the footer can be 100% (it's actually the html tag) or we can use a CSS 3 rule on #main like

#main { min-height: calc( 100vh - 3em ); }

but then we'll get new bugs on older browsers that don't support vh or calc()