bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

https sign-in page tries to load http content #54

Closed hoskins-robertj closed 10 years ago

hoskins-robertj commented 10 years ago

I use https on my login page and I get browser errors because the slideshow images and logo (and possibly more) are loaded over http. The login box is still there and works fine but the rest of the page is essentially blank, which looks bad.

thedannywahl commented 10 years ago

does this happen on teh "custom" login or the regular login? or both?

hoskins-robertj commented 10 years ago

It appears to be both.  I have only used the custom login page but just now tried the regular login.  My logo does not appear on either page.  Slideshow images don't load on the custom page.  FireBug shows me that the

where my logo should be is empty (<div id="logo">
).  I assume the image was blocked because the URL was not https:.  The logo works fine on every other page. 

Thanks for taking over Elegance.  

-Brian

On Sunday, August 10, 2014 11:10 PM, Danny Wahl notifications@github.com wrote:

does this happen on teh "custom" login or the regular login? or both? — Reply to this email directly or view it on GitHub.

thedannywahl commented 10 years ago

looking at the code for the logo- it appears to be a separate bug, the logo is actually never called, so you only end up with an empty div: https://github.com/thedannywahl/moodle-theme_elegance/blob/master/layout/login.php#L58-L62

I will check on the background images now

thedannywahl commented 10 years ago

I'm unable to replicate this on the current release version or on the development version. Here's a snapshot from a site that uses http but forces https for /login/ as you can see all resources are loaded over https and the the encryption is secure.

screen shot 2014-08-20 at 1 36 07 pm

if you have added custom css that hard-codes http please replace it with a relative url. e.g.:

#something { background:url('//path/to/image.png'); }