bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

Heading Display Sizes are not Sequential #55

Closed mrbaggins closed 10 years ago

mrbaggins commented 10 years ago

When in a course, using the heading 1 - 3 options results in h3 to h5 tags.

The h3 tag has an alternative definition elsewhere that overwrites the size of the h3 tags from 24px down to 16px.

This can be seen at the guest accessible course: http://web3.mtaustin-h.schools.nsw.edu.au/course/view.php?id=5

thedannywahl commented 10 years ago

the theme doesn't change output html tags. If you type <h1> and <h3> comes out it's definitely not the theme. Unless I'm not understanding the issue correctly.

mrbaggins commented 10 years ago

My apologies, it's what the wysiwyg editor calls "heading 1" that comes out as <h3>.

So the styles you can pick are "Heading 1, Heading 2, Heading 3, preformatted, paragraph" and that's <h3>,<h4>, <h5> <pre> and <p> respectively.

On the example course I've added a single line in the settings "Include CSS on every page" section to re set <h3> size to 24

thedannywahl commented 10 years ago

Glad you figured it out :smile:

mrbaggins commented 10 years ago

I only accidentally closed it. Not used to github for issue tracking.

So it's supposed to be overwritten with Heading 1 being 8pts smaller than heading 2?

thedannywahl commented 10 years ago

ok, I see h1 is smaller than h2.

mrbaggins commented 10 years ago

Ah, cool. Thanks for the patience. Look forward to the next one!

thedannywahl commented 10 years ago

heading sizes are now inherited from theme_bootstrap: screen shot 2014-08-20 at 12 22 28 pm

mrbaggins commented 10 years ago

Fantastic. Looking forward to updating.