bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

Quiz secure mode broken. #90

Open universityofglasgow opened 9 years ago

universityofglasgow commented 9 years ago

When quiz is running in secure mode, the layout is broken. The blocks are pushed below the content rather than being in a side-bar. The following notice is produced...

Notice: Undefined variable: regions in /path/to/moodle/theme/elegance/layout/secure.php on line 111

However, worse, it also breaks the quiz navigation. Clicking between questions (using the quiz navigation block) does NOT save the questions. It silently fails - a potential disaster in a timed exam.

The layout is fixed by adding the missing line

$regions = theme_elegance_bootstrap3_grid($hassidepost)

...which is missing from this layout (same as other layouts). However, the quiz navigation is still broken and does not save the quiz answers. Note the questions DO save when using the Bootstrap theme.

EDIT: Just noticed that the HTML editor does not load for essay type questions. It does for the Bootstrap theme.

thedannywahl commented 9 years ago

does this also happen on the parent? theme_bootstrap

On Tue, Nov 18, 2014 at 10:40 PM, universityofglasgow < notifications@github.com> wrote:

When quiz is running in secure mode, the layout is broken. The blocks are pushed below the content rather than being in a side-bar. The following notice is produced...

Notice: Undefined variable: regions in /path/to/moodle/theme/elegance/layout/secure.php on line 111

However, worse, it also breaks the quiz navigation. Clicking between questions (using the quiz navigation block) does NOT save the questions. It silently fails - a potential disaster in a timed exam.

— Reply to this email directly or view it on GitHub https://github.com/thedannywahl/moodle-theme_elegance/issues/90.

Danny Wahl iyWare.com

universityofglasgow commented 9 years ago

No. Bootstrap works.

The layout/secure.php file looks completely wrong. It doesn't appear to load the javascript bits of the page which as at the root of the issue. Simply copying over the secure.php provides a (rather incomplete) workaround if desperate.

See also https://moodle.org/mod/forum/discuss.php?d=268866