search

bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

Youtube repo link in label #94

Open tswilson opened 9 years ago

tswilson commented 9 years ago

Add activity or resource -> Label Media Browse Repositories Choose Youtube, select a video, insert Save / Return

Neither the video or the link text show in the course.

Changing theme away from Elegance, the video player appears with the correct video.

richardschwarz commented 9 years ago

Had a glance and play with Element Inspector in Chrome. Elegance inserts an extra

around the video, and strips out the height and width as shown in the More theme (I tested it in that one).

In More, the structure is: <span class="mediaplugin mediaplugin_youtube">, then straight into the <iframe> for the video, which includes a height of 300 and width of 400.

In Elegance: <span class="mediaplugin mediaplugin_youtube"> then !!! <div class="fluid-width-video-wrapper" style="padding-top: 75%;"> then the <iframe> but this time without the height and width.

By removing the div, the video shows, but tiny. Then add height and width back to the <iframe> and it it looks like a properly inserted youtube video.

I have no idea where to look for this in the code, but am more than willing to be told and try out a fix.