search

bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

class names in foreign language on top nav bar #410

Open elielsorcerer opened 8 years ago

elielsorcerer commented 8 years ago

in core_renderer.php on function render_custom_menu_item. the class is set to be the custom_menu_item title Line: 277 $class = $menunode->get_title();

that title might be in a foreign language

bootstrapbug

elielsorcerer commented 8 years ago

that since it takes the class name from the title, the class name might be in a foreign lang as well, that's the part that creates problems.

On Wed, Mar 9, 2016 at 6:51 PM, Gareth J Barnard notifications@github.com wrote:

It might be, but as your screen shot clearly shows, the 'title' attribute is set correctly to the different language. So, what's the problem?

— Reply to this email directly or view it on GitHub https://github.com/bmbrands/theme_bootstrap/issues/410#issuecomment-194392887 .

gjb2048 commented 8 years ago

So what do you suggest is the solution?

nadavkav commented 8 years ago

Trying to add more informative classes to Moodle's menus (and tree elements) so I can compose needed UI user tours, using: https://moodle.org/plugins/local_usertours I created https://tracker.moodle.org/browse/MDL-55250 And suggested patch: https://github.com/moodle/moodle/compare/master...nadavkav:MDL-55250_master Please see if it helps with this issue and also any feedback would be very much appriciated