search

bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

Create BS4 development branch #413

Closed gjb2048 closed 8 years ago

gjb2048 commented 8 years ago

Hi Bas,

What about a BS4 development branch pulled from: https://github.com/iamandrew/theme_bootstrap/tree/bootstrap4 ?

Cheers,

Gareth

bmbrands commented 8 years ago

Yes would be a good idea. Or maybe just Andrew to be a collaborator on this repo so he can push it here and have all the credit for his work

gjb2048 commented 8 years ago

Thinking without knowing, is it possible to create a 'bootstrap4_dev' branch then Andrew makes a pull request (push) on that instead of 'master' then he'd get credit? Or.... with a local repo, have his repo in the list of remotes then create the 'bootstrap4_dev' on your repo and cherry pick the commits from his: https://github.com/iamandrew/theme_bootstrap/commits/bootstrap4 ?

gjb2048 commented 8 years ago

Or... if BS4 is the future, branch now with the bootstrap3_master and 'master' be upgraded to BS4 with a pull (push) from his repo.

iamandrew commented 8 years ago

I'm happy to go with whatever option works for this. It would be good to get the work merged in to this repo as soon as possible so we can get more eyes looking and hands coding on it, especially so we can get ahead for https://moodle.org/mod/forum/discuss.php?d=334523

iamandrew commented 8 years ago

bootstrap4 branch now added.

bmbrands commented 8 years ago

Cool! Thanks Andrew