search

bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

Implement MDL-51013; suppress navbar button when custom menu is empty #416

Closed OdyX closed 8 years ago

OdyX commented 8 years ago

Also provide a translation for the 'Toggle navigation' string.

bmbrands commented 8 years ago

Thanks Didier, excellent fix and an important improvement. Cool stuff

bmbrands commented 8 years ago

I made some small changes to the indenting to make sure it passed the Travis checks. Just so you know

gjb2048 commented 8 years ago

Interesting :) - I looked at the code and the 'type' attribute is missing, so Shoehorn: https://github.com/gjb2048/moodle-theme_shoehorn/blob/master/classes/output/core_renderer.php#L132 and the W3C HTML for 'button': http://www.w3schools.com/tags/tag_button.asp

bmbrands commented 8 years ago

Thanks Gareth! You're right. I have added the type param