search

bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

#424 remove amd task #427

Closed jobyh closed 8 years ago

jobyh commented 8 years ago

OK false alarm on os mentioned in #426 however I did realise that removing the amd task means that grunt-contrib-jshint and grunt-contrib-uglify are no longer needed so I've removed those also.

Using npm uninstall --save appears to have done some of its own JSON reformatting too which is why some additional lines in package.json have changed.

bmbrands commented 8 years ago

Travis seems to find issues with this pull request. Have you any idea why?

jobyh commented 8 years ago

Looks like the jshint task failed

The command "moodle-plugin-ci jshint" exited with 1.

Ah... I wonder if it still needs jshint to install locally and removing it from package.json has broken it. I'll look into it.

I'll investigate.

jobyh commented 8 years ago

Actually the answer was just above in the Travis output (I didn't spot initially as it looked like part of a previous task). The PWD variable was only used by the uglify task which was removed.

bmbrands commented 8 years ago

Grand thanks!