bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

labels on plugin upgrade page, statusserious etc. #430

Open davidscotson opened 8 years ago

davidscotson commented 8 years ago

We should revisit the styles in less/moodle/admin.less as core have adopted Bootstrap 2 HTML for this area.

This should let us delete most of the workaround .less e.g. statusserious doesn't seem used anywhere in Moodle anymore.

But, since they used BS2 and we have BS3 we might need to extend label-danger so that it also works for the classname .label-important, and possibly target .sourcetext.label:not(.label-info) so that it's the same as .label.label-default. Both those might need limited to this specifc page to stop people using the wrong code elsewhere.

<td class="status cell c4 lastcol" style=""><span class="sourcetext label">Standard</span> <span class="statustext label label-important">To be deleted</span></td>

You may need to have old standard themes that need to be deleted on the plugins overview page to see the HTML that needs work.

I'll try to d this when I have a moment, but noting it down before I forget.

davidscotson commented 8 years ago

Actually, statusserious may still be used on the security and performance reports still.