search

bmbrands / theme_bootstrap

A Moodle theme based on the Bootstrap CSS framework
113 stars 112 forks source link

Fix #441. #442

Closed gjb2048 closed 7 years ago

gjb2048 commented 7 years ago

Hi Bas,

My fix for #441. I know I can push directly as have permission but thought you should review it instead.

Cheers,

Gareth

gjb2048 commented 7 years ago

This is the result:

2016-08-23 18_33_17-start

bmbrands commented 7 years ago

Thanks Gareth,

Before I pull this into the repo I want to do a full test for this one. The

gjb2048 commented 7 years ago

Hi Bas,

The fix is a direct copy from bootstrapbase with the files of the same name, so should be 75% correct :).

Cheers,

Gareth

Sent from my iPod in deep space...

On 26 Aug 2016, at 08:11, Bas Brands notifications@github.com wrote:

Thanks Gareth,

Before I pull this into the repo I want to do a full test for this one. The

tag is a tricky one in Moodle so I want to make sure this does not break anything. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

bmbrands commented 7 years ago

I might as well start merging and testing :)

gjb2048 commented 7 years ago

Is it possible to checkout remote branch and test it without merging?

bmbrands commented 7 years ago

I think so yes. But it is easy enough to just merge en do testing right away. This one is simple enough to change since it is just one added less file :)

gjb2048 commented 7 years ago

:)