bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

[FS-508] redfish dell bios config #311

Closed diogomatsubara closed 1 year ago

diogomatsubara commented 1 year ago

What does this PR implement/change/remove?

Implement collection of bios configuration for Dell via redfish provider.

To try it out use this gist: https://gist.github.com/diogomatsubara/343043a6397514538d415e6e79f5b169 and set the env vars accordingly.

Checklist

The HW vendor this change applies to (if applicable)

Dell

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

Add functionality to get bios configuration from Dell systems using redfish
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 13.79% and project coverage change: -0.64 :warning:

Comparison is base (eb51295) 43.73% compared to head (209e24a) 43.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== - Coverage 43.73% 43.09% -0.64% ========================================== Files 33 35 +2 Lines 2659 2717 +58 ========================================== + Hits 1163 1171 +8 - Misses 1378 1425 +47 - Partials 118 121 +3 ``` | [Impacted Files](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [bmc/bios.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-Ym1jL2Jpb3MuZ28=) | `0.00% <0.00%> (ø)` | | | [bmc/provider.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-Ym1jL3Byb3ZpZGVyLmdv) | `100.00% <ø> (ø)` | | | [client.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-Y2xpZW50Lmdv) | `24.00% <0.00%> (-0.80%)` | :arrow_down: | | [providers/redfish/inventory.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3JlZGZpc2gvaW52ZW50b3J5Lmdv) | `5.46% <ø> (ø)` | | | [providers/redfish/bios.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3JlZGZpc2gvYmlvcy5nbw==) | `57.14% <57.14%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

joelrebel commented 1 year ago

@diogomatsubara I forgot to mention, can you include the example you have here https://gist.github.com/diogomatsubara/343043a6397514538d415e6e79f5b169 in the examples directory https://github.com/bmc-toolbox/bmclib/tree/main/examples

diogomatsubara commented 1 year ago

@joelrebel added the example in 209e24a