bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

providers/redfish: fixes a panic in cases where a nil bios object was returned #317

Closed joelrebel closed 1 year ago

joelrebel commented 1 year ago

What does this PR implement/change/remove?

Fixes a nil panic in Redfish BIOS data queries.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.04 :warning:

Comparison is base (44558f0) 43.31% compared to head (ef401f6) 43.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ========================================== - Coverage 43.31% 43.28% -0.04% ========================================== Files 35 35 Lines 2731 2733 +2 ========================================== Hits 1183 1183 - Misses 1426 1427 +1 - Partials 122 123 +1 ``` | [Impacted Files](https://codecov.io/gh/bmc-toolbox/bmclib/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/redfish/bios.go](https://codecov.io/gh/bmc-toolbox/bmclib/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3JlZGZpc2gvYmlvcy5nbw==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.