bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

Add one-time filtering functionality: #325

Closed jacobweinstock closed 1 year ago

jacobweinstock commented 1 year ago

What does this PR implement/change/remove?

This enables running single methods with filtering. Improves the filtering UX.

Checklist

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 41.81% and project coverage change: +1.01 :tada:

Comparison is base (475118e) 43.67% compared to head (9cd1971) 44.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #325 +/- ## ========================================== + Coverage 43.67% 44.69% +1.01% ========================================== Files 35 36 +1 Lines 2761 2797 +36 ========================================== + Hits 1206 1250 +44 + Misses 1432 1422 -10 - Partials 123 125 +2 ``` | [Impacted Files](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [filter.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-ZmlsdGVyLmdv) | `20.00% <20.00%> (ø)` | | | [client.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-Y2xpZW50Lmdv) | `52.07% <54.28%> (+20.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

joelrebel commented 1 year ago

Hey @jacobweinstock thanks for implementing this! It looks good to me, I'll test it out on some hardware and report back.

joelrebel commented 1 year ago

This LGTM! just needs a rebase on main.