search

bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

SEK-322 Sol and ciphers #340

Closed nuclearbob closed 1 year ago

nuclearbob commented 1 year ago

What does this PR implement/change/remove?

IPMI functions for sol and getciphers Example files demonstrating usage of those functions

Checklist

I intend to write tests that use these functions, but I have not written tests for the functions themselves. If there is a good place to add those, I can.

Description for changelog/release notes

IPMI sol and getciphers functions added for use in hardware testing
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.12% :warning:

Comparison is base (a1b87e2) 42.67% compared to head (9f1fd20) 42.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #340 +/- ## ========================================== - Coverage 42.67% 42.55% -0.12% ========================================== Files 44 44 Lines 3691 3701 +10 ========================================== Hits 1575 1575 - Misses 1937 1947 +10 Partials 179 179 ``` | [Files Changed](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/ipmitool/ipmitool.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL2lwbWl0b29sL2lwbWl0b29sLmdv) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nuclearbob commented 1 year ago

This seems fine to me, I've left a few comments inline. It would be worth testing on multiple hardware to verify certain string comparisons work consistently.

I'm working on the changes you requested. I noticed several checks failed as well. I think I addressed the lint issue, but I'm not sure what to do about codecov. Is there a way to write the examples as tests, or do tests need to be written separately, or is that something I don't need to pay attention to yet?

nuclearbob commented 1 year ago

The scope on this got a little big for what we really wanted to do (basic output verification of 5 ipmitool calls) so we implemented an alternate connector for the testsuite. We may revisit the feature addition later.