codecov[bot]
commented
1 year ago Codecov Report
Patch coverage has no change and project coverage change: +0.01% :tada:
Comparison is base (
b9b7ef8) 44.55% compared to head (3216ab0) 44.56%.:exclamation: Current head 3216ab0 differs from pull request most recent head 730ce0d. Consider uploading reports for the commit 730ce0d to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #350 +/- ## ========================================== + Coverage 44.55% 44.56% +0.01% ========================================== Files 51 51 Lines 4105 4104 -1 ========================================== Hits 1829 1829 + Misses 2066 2065 -1 Partials 210 210 ``` | [Files Changed](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/rpc/http.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3JwYy9odHRwLmdv) | `66.66% <0.00%> (+1.80%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What does this PR implement/change/remove?
In testing this was causing issues with consumers of the provider using the error string. Also, for security reasons we might not want to return an arbitrary response body, especially when it doesn't conform to the response contract.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes