bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
193 stars 36 forks source link

Fix session leak in Dell provider: #356

Closed jacobweinstock closed 1 year ago

jacobweinstock commented 1 year ago

What does this PR implement/change/remove?

This was leaving open sessions in non Dell machines. Closed sessions when the Dell Open function returns error after successfully opening.

Checklist

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b6af042) 44.93% compared to head (91966ac) 45.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #356 +/- ## ========================================== + Coverage 44.93% 45.05% +0.12% ========================================== Files 54 54 Lines 4206 4208 +2 ========================================== + Hits 1890 1896 +6 + Misses 2108 2104 -4 Partials 208 208 ``` | [Files](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/dell/idrac.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL2RlbGwvaWRyYWMuZ28=) | `46.22% <0.00%> (+4.88%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.