bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

e3c256d4i support #357

Closed ofaurax closed 1 year ago

ofaurax commented 1 year ago

By default, update is broken on e3c256d4i. This PR fixes it. Compatibility with e3c246d4i needs to be tested

codecov[bot] commented 1 year ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (153e11d) 45.05% compared to head (e63714c) 45.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== + Coverage 45.05% 45.08% +0.02% ========================================== Files 54 54 Lines 4208 4228 +20 ========================================== + Hits 1896 1906 +10 - Misses 2104 2110 +6 - Partials 208 212 +4 ``` | [Files](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/asrockrack/helpers.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL2Fzcm9ja3JhY2svaGVscGVycy5nbw==) | `49.44% <63.63%> (+0.40%)` | :arrow_up: | | [providers/asrockrack/firmware.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL2Fzcm9ja3JhY2svZmlybXdhcmUuZ28=) | `12.71% <50.00%> (+2.52%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.