bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
193 stars 36 forks source link

[3/3] supermicro firmware install rewrite #363

Closed joelrebel closed 11 months ago

joelrebel commented 12 months ago

What does this PR implement/change/remove?

Checklist

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (new-firmware-interfaces@49efe08). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## new-firmware-interfaces #363 +/- ## ========================================================== Coverage ? 45.02% ========================================================== Files ? 60 Lines ? 5017 Branches ? 0 ========================================================== Hits ? 2259 Misses ? 2501 Partials ? 257 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelrebel commented 12 months ago

rebased on parent branch, fixed up FirmwareUpload interface method to accept a *os.File.