search

bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

Supermicro no CSRF #364

Closed joelrebel closed 1 year ago

joelrebel commented 1 year ago

What does this PR implement/change/remove?

Supermicro X11s running on older firmware don't have CSRF support and this change removes the requirement to have a CSRF token so firmware can be updated on those devices.

Checklist

The HW vendor this change applies to (if applicable)

Supermicro X11s running BMC firmware 01.71.11 10/25/2019 and older

The HW model number, product name this change applies to (if applicable)

X11DPH-T

codecov[bot] commented 1 year ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d7662f2) 44.83% compared to head (f0ee7ed) 45.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## redfishwrapper-changes #364 +/- ## ========================================================== + Coverage 44.83% 45.03% +0.19% ========================================================== Files 60 60 Lines 5070 5021 -49 ========================================================== - Hits 2273 2261 -12 + Misses 2540 2504 -36 + Partials 257 256 -1 ``` | [Files](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [providers/supermicro/firmware.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3N1cGVybWljcm8vZmlybXdhcmUuZ28=) | `0.00% <ø> (ø)` | | | [providers/supermicro/supermicro.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3N1cGVybWljcm8vc3VwZXJtaWNyby5nbw==) | `45.33% <100.00%> (+0.39%)` | :arrow_up: | | [providers/supermicro/x11\_firmware\_bmc.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3N1cGVybWljcm8veDExX2Zpcm13YXJlX2JtYy5nbw==) | `68.54% <100.00%> (+0.51%)` | :arrow_up: | | [providers/supermicro/floppy.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3N1cGVybWljcm8vZmxvcHB5Lmdv) | `0.00% <0.00%> (ø)` | | | [providers/supermicro/x11\_firmware\_bios.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3N1cGVybWljcm8veDExX2Zpcm13YXJlX2Jpb3MuZ28=) | `6.10% <0.00%> (-0.06%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.