bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
189 stars 36 forks source link

Adds tracing for client methods #365

Closed joelrebel closed 10 months ago

joelrebel commented 10 months ago

What does this PR implement/change/remove?

Adds the WithTraceProvider() client option to accept a trace provider, with a trace provider, the client methods are traced with annotations from the client metadata.

Checklist

Description for changelog/release notes

codecov[bot] commented 10 months ago

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (4666b85) 44.99% compared to head (2f99df1) 44.29%.

Files Patch % Lines
client.go 7.95% 81 Missing :warning:
bmc/bmc.go 15.78% 16 Missing :warning:
option.go 0.00% 4 Missing :warning:
bmc/firmware.go 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 44.99% 44.29% -0.70% ========================================== Files 60 61 +1 Lines 5025 5145 +120 ========================================== + Hits 2261 2279 +18 - Misses 2508 2610 +102 Partials 256 256 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.