bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

Taskstate constant #368

Closed joelrebel closed 1 year ago

joelrebel commented 1 year ago

What does this PR implement/change/remove?

Updates the FirmwareTaskVerifier interface and its implementations to return a constant.TaskState type.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b0ef181) 44.29% compared to head (6c585e6) 44.40%.

Files Patch % Lines
providers/supermicro/x11_firmware_bios.go 0.00% 11 Missing :warning:
providers/supermicro/x11_firmware_bmc.go 71.42% 2 Missing :warning:
client.go 0.00% 1 Missing :warning:
providers/supermicro/firmware.go 0.00% 1 Missing :warning:
providers/supermicro/x11.go 0.00% 1 Missing :warning:
providers/supermicro/x12.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== + Coverage 44.29% 44.40% +0.10% ========================================== Files 61 61 Lines 5145 5155 +10 ========================================== + Hits 2279 2289 +10 Misses 2610 2610 Partials 256 256 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.