bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
193 stars 36 forks source link

Update firmware install status for scheduling state #373

Closed coffeefreak101 closed 10 months ago

coffeefreak101 commented 11 months ago

What does this PR implement/change/remove?

During my firmware update testing, I encountered a situation where the firmware update status went from "initializing" to "running" for just a second, then to "powercycle-host" then back to "running".

This occurred because the BMC's "scheduling" state gets reported as "running", and the "scheduled" state is reported as "powercycle-host".

This change moves "scheduling" BMC state to the "initializing" firmware update status.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b299d27) 43.47% compared to head (1e2d807) 43.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #373 +/- ## ======================================= Coverage 43.47% 43.47% ======================================= Files 59 59 Lines 5274 5274 ======================================= Hits 2293 2293 Misses 2762 2762 Partials 219 219 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelrebel commented 11 months ago

good catch, Since theres an ongoing overhaul in this area - do you mind basing this PR off this branch https://github.com/bmc-toolbox/bmclib/tree/redfish-dell

coffeefreak101 commented 11 months ago

good catch, Since theres an ongoing overhaul in this area - do you mind basing this PR off this branch https://github.com/bmc-toolbox/bmclib/tree/redfish-dell

I see you're moving the firmware file in that branch. Looks like your PR has the approvals. I can wait for that to merge first before merging this one.

coffeefreak101 commented 10 months ago

@joelrebel

I rebased and fixed this base on the new code.