search

bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
193 stars 36 forks source link

redfishwrapper changes #374

Closed joelrebel closed 11 months ago

joelrebel commented 11 months ago

What does this PR implement/change/remove?

cumulative devel work merge from these approved PRs

https://github.com/bmc-toolbox/bmclib/pull/369 https://github.com/bmc-toolbox/bmclib/pull/370 https://github.com/bmc-toolbox/bmclib/pull/371 https://github.com/bmc-toolbox/bmclib/pull/372

codecov[bot] commented 11 months ago

Codecov Report

Attention: 226 lines in your changes are missing coverage. Please review.

Comparison is base (b565dd4) 44.60% compared to head (afda0c3) 43.87%.

Files Patch % Lines
providers/dell/firmware.go 9.34% 96 Missing and 1 partial :warning:
internal/redfishwrapper/inventory.go 11.76% 45 Missing :warning:
internal/redfishwrapper/inventory_collect.go 10.34% 26 Missing :warning:
providers/supermicro/supermicro.go 30.43% 14 Missing and 2 partials :warning:
internal/redfishwrapper/power.go 0.00% 14 Missing :warning:
client.go 0.00% 7 Missing :warning:
internal/redfishwrapper/task.go 76.19% 3 Missing and 2 partials :warning:
providers/redfish/redfish.go 0.00% 5 Missing :warning:
providers/dell/idrac.go 69.23% 4 Missing :warning:
internal/redfishwrapper/system.go 40.00% 3 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== - Coverage 44.60% 43.87% -0.74% ========================================== Files 61 59 -2 Lines 5206 5042 -164 ========================================== - Hits 2322 2212 -110 + Misses 2628 2608 -20 + Partials 256 222 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.