search

bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
194 stars 37 forks source link

Update virtual media mounting: #398

Closed jacobweinstock closed 1 month ago

jacobweinstock commented 1 month ago

What does this PR implement/change/remove?

At least one BMC, Supermicro X11SDV-4C-TLN2F, did not support setting inserted and/or writeProtected in the payload properties in redfish calls to do a virtual media mount. This falls back to not using them if the initial call with them in the properties fails.

This was test and worked successfully on a Supermicro (X11SDV-4C-TLN2F), HP ILO5, and Dell iDRAC9.

Checklist

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

jacobweinstock commented 1 month ago

Thanks for adding SMC support and testing this out, would you mind adding in an example snippet for reference into https://github.com/bmc-toolbox/bmclib/tree/main/examples

Thanks for the review. Will add an example.

jacobweinstock commented 1 month ago

@joelrebel , ready for another review. please and thank you!