search

bmc0 / dsp

An audio processing program with an interactive mode.
ISC License
219 stars 31 forks source link

Can't handle decimal in dsp config file, Audacious and LMMS crash. #32

Closed mzpsh closed 6 years ago

mzpsh commented 6 years ago

Seems like dsp can't handle decimal in config file, even as simple as "-4.6". Tried not to use decimal, like "-4" and it works, no more crash. This affect gain and eq effect, haven't tried other effect.

This affect Audacious and LMMS, seems like other program is affected too.

Distro: Arch Linux dsp version from AUR: latest from git Audacious version: 3.9 LMMS version: 1.1.3

Terminal output of audacious:

ladspa_dsp: gain: failed to parse gain: -4.6
ladspa_dsp: error: failed to initialize effect: gain
Kerusakan segmentasi (core didump)

terminal output of lmms:

ladspa_dsp: gain: failed to parse gain: -4.6
ladspa_dsp: error: failed to initialize effect: gain
Kerusakan segmentasi (core didump)

My ~/.config/ladspa_dsp/config file: effects_chain=gain -4.6

mzpsh commented 6 years ago

Just read the readme again. Sorry.

bmc0 commented 6 years ago

Regarding the segfaults:

Audacious doesn't check the return value of instantiate() like it should (code here), so it crashes if instantiate() fails (NULL pointer dereference).

I'm not quite sure why LMMS crashes. Maybe it calls cleanup() even when instantiate() fails? I haven't really had a proper look at the code.

mzpsh commented 6 years ago

BTW, I moved to a new system, and not putting LC_NUMERIC option.