search

bmcage / odes

The ODES scikit for ordinary differential and algebraic equations, an extension to scipy
https://scikits-odes.readthedocs.io/
Other
124 stars 44 forks source link

Sundials version recommended in the docs appears to be wrong #145

Open callegar opened 1 year ago

callegar commented 1 year ago

The project documentation at https://scikits-odes.readthedocs.io/en/stable/installation.html#requirements-before-install indicates that there is a requirement for Sundials 5.1.0, but the installation of odes fails with this Sundials version.

Usage of sundials_context.h suggests that a quite recent version of SunDials is needed. It may be the case that the version provided by many linux distros (including the relatively recent Ubuntu 22.04) can be too old (I think it is 5.8 in ubuntu 22.04). Can a recommended and minimal version be indicated?

aragilar commented 1 year ago

Oops, sorry, I didn't see that when I did the latest release today. Any 6.* release should work. If you need something that works on older sundials, scikits.odes 2.6.5 is want you want.

callegar commented 1 year ago

Not to pressure you, but just to provide correct advice to colleagues using odes: will the 2.6.x odes version working with sundials 5.x that is present in most LTS distros receive updates if issues are found? Namely, will there be a 2.6.6 if something turns out to be wrong in 2.6.5 or to be sure to receive updates if bugs are found one should now use 2.7.x?

aragilar commented 1 year ago

I'm not opposed to doing a 2.6.6 if something major happens, but as SUNDIALS seems to have finished with their 5.x series, I don't expect that to occur. The main issue you will likely see is around the numpy.distutils changes, so as long as you stick to a older python/numpy, there should be no issues. I'm not planning on backporting whatever changes we end up doing to move away from numpy.distutils (I'd have liked to support SUNDIALS 5 and 6, but I don't have much time, and SUNDIALS does tend to change things every release, once I redo the build system, I will likely go through the low-level Cython pxd files and clean them up).