search

bmcclure / CakePHP-Media-Plugin

A CakePHP (2.0) plugin enabling transfer/manipulation/embedding of files in 23 ways.
Other
60 stars 24 forks source link

Remove workarounds for older PHP versions #53

Closed ndm2 closed 10 years ago

ndm2 commented 10 years ago

This patch removes the workarounds for PHP versions < 5.2.0 where PATHINFO_FILENAME support is missing. The CakePHP core already requires PHP 5.2.8 as a minimum, not to mention that this functionality is used in the GeneratorBehaviour class since ages, so these workarounds should be be safe to drop.

bmcclure commented 10 years ago

Good catch! Thanks for helping to clean up the code!

ndm2 commented 10 years ago

Yet another segfault... if this keeps happening it might be something worth to investigate.

bmcclure commented 10 years ago

Re-ran and it was successful this time. Does make me wonder why this seems to be a recurring event with this project, but there doesn't seem to be much consistency with when it fails.

ndm2 commented 10 years ago

Yep, pretty hard to tell, though in the end it's most probably a bug (outside of this projects code) or faulty RAM. The next PR is on its way, we'll see if this keeps happening.