bmcclure / ha-chore-helper

A Home Assistant helper integration for managing recurring chores.
MIT License
53 stars 5 forks source link

Chores come overdue the day after completing them #33

Open dlprows opened 10 months ago

dlprows commented 10 months ago

System Health details

System Information

version core-2023.10.3
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.11.5
os_name Linux
os_version 6.1.56
arch x86_64
timezone America/Denver
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4996 Installed Version | 1.33.0 Stage | running Available Repositories | 1317 Downloaded Repositories | 11
Home Assistant Cloud logged_in | false -- | -- can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 11.0 -- | -- update_channel | stable supervisor_version | supervisor-2023.10.1 agent_version | 1.6.0 docker_version | 24.0.6 disk_total | 30.8 GB disk_used | 11.4 GB healthy | true supported | true board | ova supervisor_api | ok version_api | ok installed_addons | Studio Code Server (5.13.0), Mosquitto broker (6.3.1), Ring-MQTT with Video Streaming (5.6.3), Z-Wave JS (0.2.0), TasmoAdmin (0.25.1), Terminal & SSH (9.7.1), ESPHome (2023.10.1)
Dashboards dashboards | 1 -- | -- resources | 11 views | 6 mode | storage
Recorder oldest_recorder_run | October 17, 2023 at 4:29 AM -- | -- current_recorder_run | October 16, 2023 at 10:29 PM estimated_db_size | 196.07 MiB database_engine | sqlite database_version | 3.41.2

Checklist

Describe the issue

I have an “every [x] weeks” chore that has Saturday as a due day. My dashboard filters to state <= 0

on Saturdays, the chore shows up as due. I complete it, and it disappears from the dashboard

the next day it shows up again as 1 day overdue

is this something that I’m doing wrong, or something that I can provide any more information on? It doesn’t seem like something that logs would help with because it’s not a crash. It’s just kind of annoying to have to complete it again the day after I already completed it

Reproduction steps

  1. Complete an every x weeks chore on its due day
  2. It pops up as overdue the next day

Debug logs

Doesn’t seem applicable. But I can do this if you say I’m wrong

Diagnostics dump

No response

bmcclure commented 7 months ago

I'm so sorry for the delayed response!

Hm, the chore state should be the number of days until (or since) due, so I think your filter makes sense, but the chore state is perhaps not updating properly when completed for some reason.

Can you post all the attributes for that chore that's causing an issue? Also, have you had other chores work properly, or are you experiencing this with every chore you create?

Thanks!

WallSecurity commented 7 months ago

Hi there,

Just had this happening to me today with an "every day" chore.

Posting pictures showing how the chore is setup.

The history picture shows, that the due date of the chore was correctly set to next day ( = 1) at around 7PM and then was reduced to -1 at midnight when the chore was updated by the integration.

2024-01-31 14_32_02-Overview – Home Assistant 2024-01-31 14_32_15-Overview – Home Assistant 2024-01-31 14_32_26-Overview – Home Assistant

WallSecurity commented 7 months ago

@bmcclure

Happens with weekly tasks as well:

2024-02-01 07_19_40-Overview – Home Assistant 2024-02-01 07_19_28-Overview – Home Assistant 2024-02-01 07_19_53-Overview – Home Assistant

tieu1991 commented 7 months ago

It seems to happen only with "Every" chores not the "After" chores

WallSecurity commented 6 months ago

Hi everyone, Seems like this is, unfortunately, no longer maintained. I tried to fix the issue myself, but the code is not commented well and made it quite hard to pinpoint the issue. I think I might have identified the issue and I am currently testing it. Worked for the last 2 weeks now. If someone wants to help me out here, feel free to use my fork.

bmcclure commented 2 months ago

Sorry I've been away from this integration for a bit, but I am still here. I will look into fixing this, but if @WallSecurity's fork has improvements then a pull request for those would also greatly be appreciated.