search

bmcfee / crema

convolutional and recurrent estimators for music analysis
BSD 2-Clause "Simplified" License
84 stars 22 forks source link

update: keras import #35

Closed e7mac closed 2 years ago

e7mac commented 2 years ago

The newer versions (I think 2.5+) of keras no longer have keras.engine.topology and the Layer class needs to be imported from keras.layers instead

bmcfee commented 2 years ago

Thanks for this.

I know that this repository is badly in need of some maintenance, but if you're proposing a change in response to a newer version of a dependency, then two things need to be included:

  1. The version should be updated appropriately in the package specification (setup.py)
  2. The unit tests should run on an updated environment.

I propose holding off on merging this patch until we can get continuous integration testing running again. This likely requires a migration to github actions, and I don't actually have the time or bandwidth to handle that right now.

bmcfee commented 2 years ago

I'm rolling in some updates to this along with the upstream library pumpp, so hopefully this will all be modernized in the near future.

bmcfee commented 2 years ago

Fixed by merging #36