search

bmcfee / muda

A library for augmenting annotated audio data
ISC License
232 stars 33 forks source link

Added cffi dependency #28

Closed jfsantos closed 8 years ago

jfsantos commented 8 years ago

The package does not require 'cffi' to install, but will throw an ImportError if cffi is not available, so I added it as a dependency.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 97.917% when pulling 351d649ba6c83e9ed4714c1e61c5bd76190d6328 on jfsantos:patch-1 into 13cb7004bfdbfd7e76a4f4a21af8162b97ea2ecb on bmcfee:master.

bmcfee commented 8 years ago

The package does not require 'cffi' to install, but will throw an ImportError if cffi is not available, so I added it as a dependency.

That's strange -- can you provide a complete traceback of this happening? I don't think muda is the correct place to add this dependency.

jfsantos commented 8 years ago

Sorry, I didn't check your code to find if muda was using cffi. PySoundFile uses cffi, but cffi is listed in install_requires for that package. I'll try again on a freshly created Python env and report back.

jfsantos commented 8 years ago

All right, that's clearly not an issue with muda and apparently PySoundFile is doing it right, so I'm closing this. Not sure on what caused it to happen.