Addressed deprecation of pitch_hz namespace in the pitch deformer

bmcfee / muda

A library for augmenting annotated audio data

ISC License

230 stars 33 forks source link

Addressed deprecation of pitch_hz namespace in the pitch deformer #68

Closed cwitkowitz closed 5 years ago

cwitkowitz commented 5 years ago

This change is

cwitkowitz commented 5 years ago

Changes should also be made for the deprecation of pitch_midi, but I only needed to fix pitch_hz for now...

bmcfee commented 5 years ago

Thanks for doing this! Would you mind rolling back the deletion of pitch_hz? I know it's deprecated, but there's no harm in keeping support for it here. Adding pitch_contour is :100: though.

cwitkowitz commented 5 years ago

Hold off on completing the request. I'm seeing an error on my side.

cwitkowitz commented 5 years ago

Alright. Should be ready to go. My environment was not treating the methods as static for some reason. Restarting fixed it.

cwitkowitz commented 5 years ago

Hey. Just want to remind you that this is good to merge.

bmcfee commented 5 years ago

Thanks for the reminder, and the PR! :shipit: