bmcfee / muda

A library for augmenting annotated audio data
ISC License
230 stars 33 forks source link

[WIP] trimming bug in IR Convolution #73

Closed bmcfee closed 4 years ago

bmcfee commented 4 years ago

The IR deformer uses mode='same' convolution, which centers the output with respect to the input. This leads to errors in timing alignment and trimming.

This PR fixes the convolver to use mode='full' with zero-padding. This should at least produce coherent audio, but we do need to work out the timing alignment.


This change is Reviewable