search

bmcfee / muda

A library for augmenting annotated audio data
ISC License
230 stars 33 forks source link

Old jams BackgroundNoise lacking start and stop #79

Open grudloff opened 4 years ago

grudloff commented 4 years ago

Hello!

I am reproducing a paper by Salomon & Bello, and need to make transformations according to the jams files in UrbanSound8K-JAMS, for which I am using muda.replay().

It seems that they used a previous version of Background noise which didn't use start and stop parameters, probably prior to this commit. I am thinking of just setting a default value for the case where there is no start and stop in the status, something like this:

try:
     start = state['start']
     stop = state['stop']
except  KeyError:
     start = 0
     stop = len(mudabox._audio['y'])

I will post if this works fine latter on. Would appreciate some feedback on this.

grudloff commented 4 years ago

Just thought about it again and I think the best is just to downgrade to an old version. I will leave this here anyways in case someone else stumbles with this issue.

bmcfee commented 4 years ago

Thanks for noting that! I agree that rolling back is probably the easiest solution here.

grudloff commented 4 years ago

Hello! Thanks for your kind response! In the end I opted for making a fork and rolling back only the background.py file. I will leave the link here in case it is useful for anyone. link