Closed jatinkhilnani closed 4 years ago
It looks like this PR only includes the cosmetic fixes?
clipping.py
with testspytest
latest version (5.4.3)test_deformers
xfail
markers for Clipping
method. The same is not working for LinearClipping
& RandomClipping
Along with changes per review comments, included the ones mentioned in comment above (not for older tests). Modified config to include pytest-cov==2.9.0
, since v2.10.0 required pytest>=4.6
creating a conflict and causing build failure.
This does not completely resolve the CI check issues due to llvmlite>=0.31.0dev0->numba>=0.43.0->librosa>=0.4
, as both the former packages are now compatible only with Python>=3.6. I see that librosa
CI checks are now only performed for compatible Python versions. I suppose that needs to be modified here as well, or is there a workaround?
Thanks @jatinkhilnani ! I'll take the dependency issue in a separate thread, but yeah, we're generally overdue for some modernization.
Thank you for the same. I have created another PR #82 for filter deformer, can include modernization (#81) changes in that one or contribute separately as well. Please suggest.