bmcfee / muda

A library for augmenting annotated audio data
ISC License
230 stars 33 forks source link

ColoredNoise deformer bug #84

Open lylyhan opened 3 years ago

lylyhan commented 3 years ago

error (dimension mismatch) occurs when applying a pipeline that includes coloredNoise deformer and IRConvolution deformer.

Screen Shot 2020-08-24 at 2 50 17 PM

where the original audio length is 118882 samples, impulse response length is 192000 samples.

bmcfee commented 3 years ago

The problem comes from this chunk: https://github.com/bmcfee/muda/blob/master/muda/deformers/colorednoise.py#L43-L59

The issue is that we're using rfft, but not explicitly setting the signal length when calling irfft, so odd-length signals get corrupted.

I'll rewrite this module some time soon.