search

bmcfee / presets

A python module to manipulate default parameters of a module's functions
ISC License
3 stars 1 forks source link

obsolete module #14

Open Nilsonfsilva opened 8 months ago

Nilsonfsilva commented 8 months ago

Hi! I'm a maintainer of your project on Debian! Recently presets had an error during construction. The 'imp' module has been discontinued since Python version 3.4.

I applied this patch to solve the problem. If you want to incorporate it in the next version.

Big thanks!

Index: presets/setup.py

--- presets.orig/setup.py +++ presets/setup.py @@ -1,8 +1,11 @@ from setuptools import setup, find_packages

-import imp +from importlib.machinery import SourceFileLoader

-version = imp.load_source('presets.version', 'presets/version.py') +version = SourceFileLoader('presets.version', 'presets/version.py').load_module() + +#import imp +#version = imp.load_source('presets.version', 'presets/version.py')

setup( name='presets',

bmcfee commented 8 months ago

Hi Nilson,

Thanks for the patch suggestion. Unfortunately, I don't think this will work as a patch since it would break the minimim supported python version specified in the package metadata. Would you be able to revise this as a pull request that we can test properly?