codecov-commenter
commented
2 years ago Codecov Report
Merging #90 (a339164) into main (0a44472) will decrease coverage by
0.88%. The diff coverage is80.00%.
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 83.49% 82.60% -0.89%
==========================================
Files 4 4
Lines 103 92 -11
==========================================
- Hits 86 76 -10
+ Misses 17 16 -1 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 82.60% <80.00%> (-0.89%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| resampy/filters.py | 78.37% <0.00%> (-0.57%) |
:arrow_down: |
| resampy/core.py | 83.33% <100.00%> (-1.15%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0a44472...a339164. Read the comment docs.
This PR should resolve #73 , and provides a few other simplifications and cleanups within the code algorithm.
It bumps the minimal numpy to 1.17 (for improved zeros_like behavior) and numba to 0.41 (mainly due to availability on conda-forge).
It also adds a minimal CI environment for our oldest dependency versions. In setting this up, I realized that we don't really need scipy at runtime, so I've made it a test-only dependency. This isn't a huge change (default filter is now Hann instead of Blackman-Harris; the default is not used by the user-facing API though), and I expect that anyone using resampy will have scipy anyway. The reason to drop it as a dependency is that it simplifies our minimal version spec.