search

bmcmahen / react-wysiwyg

retain some control over contenteditable input
169 stars 37 forks source link

Added option to run onEnterKey function even if textfield is not empt… #9

Closed oddis closed 9 years ago

oddis commented 9 years ago

I needed the possibility to save (i.e run onEnterKey) when you press 'enter' and the textfield is not empty.

New prop: saveOnEnterKey=[true | false]

If there is another way to achieve this functionality please disregard this pull request. (And I would be interested to know how. :) )

bmcmahen commented 9 years ago

Thanks oddis. I have a few ideas on how to refactor this component to make it a bit more flexible. Ideally, I think, we'd use React's cloneWithProps utility instead of creating a new element. I also need to think a bit more about accessibility issues here...

Anyway, I will merge this PR for now since I'm not sure when I'll be able to get to the refactor.

oddis commented 9 years ago

Thats great, thanks!

There is a good possibility that I will get an accessibility requirement on this component, so maybe I'll send another PR soon.

Will there be a version 1.0.7 available in npm?

bmcmahen commented 9 years ago

I've just published v1.1 (I think that's the correct semantic version). I'll happily accept any PR for accessibility improvements :+1:

Thanks again.