search

bmcmahen / toasted-notes

simple, flexible toast notifications for react
https://toasted-notes.netlify.com
255 stars 28 forks source link

it throw error with the new version react-spring, react-spring is in beta and interface changed! #16

Open heerzhang opened 4 years ago

bmcmahen commented 4 years ago

So weird... it's working for me when I clone this repo and use storybook. Can you try the same? Out of curiosity, and you using yarn or npm?

heerzhang commented 4 years ago

I use Sancho + react-spring, while Sancho use toasted-notes, it was nested dependency. toasted-notes can move to the new version react-spring ? My projecct use "react-spring": "^9.0.0-beta.31",

TadewosBell commented 4 years ago

has there been a fix?

TadewosBell commented 4 years ago

i am getting Cannot read property 'ref' of null

on Message.js line 68 const transition = useTransition(localShow, null, animation);

LiteSoul commented 4 years ago

Yes, it trows error re. react-spring if you try to add toasted-notes. I'm using Yarn. And this is a new project.

toast-error

bmcmahen commented 4 years ago

react-spring is now listed as a peer dependency, so currently you need to install it yourself.

Unfortunately I just don't have much time to work on this repo recently. I'd eventually like to just rewrite it - made the mistake of switching to the react-spring 9 beta, which has resulted in some of these dependency problems.

heerzhang commented 4 years ago

I change react-spring to 8.0.27 in both sancho and my Project, but sill get error： Scroll to{ }? or, web.js of react-spring;

heerzhang commented 4 years ago

my package.json: :
"name": "frontend-sei", "dependencies": { "react-spring": "8.0.27", "sancho || customize-easy-ui-component" : "3.5.7-hez04", "react-gesture-view": "^2.1.3", "react-gesture-stack": "^1.3.2", }, "peerDependencies": { },

LiteSoul commented 4 years ago

react-spring is now listed as a peer dependency, so currently you need to install it yourself.

Unfortunately I just don't have much time to work on this repo recently. I'd eventually like to just rewrite it - made the mistake of switching to the react-spring 9 beta, which has resulted in some of these dependency problems.

Yes, installing react-spring solves the problem. Sad to hear you don't have time lately

TadewosBell commented 4 years ago

how did you solve this issue? i have production web app that depends on this and keeps breaking.

bmcmahen commented 4 years ago

have you installed react-spring v8 as a peer dependency?

TadewosBell commented 4 years ago

yes, that solved the issue.Is there a way to stop it from breaking if i run npm update

zachintosh commented 4 years ago

I am on version 9 (latest beta) and am currently having this issue. Has there been any other issues related to this that might point me to a solution?