search

bmcorser / fontawesome-markdown

Markdown extension to use Font Awesome icons in a GitHub style
http://bmcorser.github.io/fontawesome-markdown/
45 stars 24 forks source link

Update font awesome v5.2 #12

Closed watahani closed 5 years ago

watahani commented 5 years ago

Font Awesome v5.2 support #11

>>> markdown.convert('i ♥ :far fa-fontawesome fa-x3:')
<p>i ♥ <i class="far fa-fontawesome fa-x3"></i></p>

Issue

I’m not an expert of pythonia. Some code might not be idiomatic Python ;)

This is breaking change. Old icon name will not be supported. The solution solve it is support shims but I won't. https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4

Please merge this PR or I'll publish it as another forked extension.

How do you think @bmcorser ?

bmcorser commented 5 years ago

Thanks for the PR, I've left some comments but in principal have to problem moving to a newer version of FontAwesome.

Please change the version here to 0.3.0 (or maybe 0.5.0 if you think that's better), so people can continue to use the older version if it suits them.

watahani commented 5 years ago

Sorry for late reply. I fixed some issues. please review.

bmcorser commented 5 years ago

Thanks for the PR, apologies for taking months to review!