search

bmcorser / fontawesome-markdown

Markdown extension to use Font Awesome icons in a GitHub style
http://bmcorser.github.io/fontawesome-markdown/
45 stars 24 forks source link

Allow importing via extension name #5

Closed bcaller closed 8 years ago

bcaller commented 8 years ago

I use Pelican. Most other MD_EXTENSIONS allow importing via name rather than an actual import.

See Supporting extension names as strings

bcaller commented 8 years ago

woops. just saw the closed issue #1 linking to pelicanfly. Though maybe this solution is simpler than the module which adds itself to MD_EXTENSIONS.

bcaller commented 8 years ago

Also, can someone explain what I did to break the travis build?

bmcorser commented 8 years ago

Thanks for the contribution. This extension was developed for use with Pelican, as you discovered ;), but I'm happy to include your change. Since this is a nicer way to include the extension (why do the import if you don't need to), feel free to update the README to only show the string-style usage.

Looking at the output, it would appear the breakage in the build is the result of some upstream change in Pip ...

Support for Python 3.0-3.2 has been dropped. Future versions will fail here.

I've dropped py32 from the tox config, so rebasing here should green your branch.

bmcorser commented 8 years ago

:+1: